On Tue, Aug 13, 2024 at 09:37:07AM -0700, Isaku Yamahata wrote: > On Mon, Aug 12, 2024 at 03:48:03PM -0700, > Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx> wrote: > > > diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c > > index b1c885ce8c9c..de14e80d8f3a 100644 > > --- a/arch/x86/kvm/vmx/tdx.c > > +++ b/arch/x86/kvm/vmx/tdx.c > > @@ -2,6 +2,7 @@ > > #include <linux/cpu.h> > > #include <asm/tdx.h> > > #include "capabilities.h" > > +#include "x86_ops.h" > > #include "tdx.h" > > > > #undef pr_fmt > > @@ -29,6 +30,37 @@ static void __used tdx_guest_keyid_free(int keyid) > > ida_free(&tdx_guest_keyid_pool, keyid); > > } > > > > +int tdx_vm_ioctl(struct kvm *kvm, void __user *argp) > > +{ > > + struct kvm_tdx_cmd tdx_cmd; > > + int r; > > + > > + if (copy_from_user(&tdx_cmd, argp, sizeof(struct kvm_tdx_cmd))) > > + return -EFAULT; > > + > > + /* > > + * Userspace should never set @error. It is used to fill > > nitpick: @hw_error Thanks will do a patch for this. Tony