On Thu, Aug 29, 2024 at 08:24:25AM +0300, Tony Lindgren wrote: > On Tue, Aug 13, 2024 at 02:08:40PM +0800, Binbin Wu wrote: > > On 8/13/2024 6:47 AM, Rick Edgecombe wrote: > > > From: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > > > --- a/arch/x86/include/asm/shared/tdx.h > > > +++ b/arch/x86/include/asm/shared/tdx.h > > > @@ -28,6 +28,12 @@ > > > #define TDVMCALL_STATUS_RETRY 1 > > > +/* > > > + * TDG.VP.VMCALL Status Codes (returned in R10) > > > + */ > > > +#define TDVMCALL_SUCCESS 0x0000000000000000ULL > > > +#define TDVMCALL_INVALID_OPERAND 0x8000000000000000ULL > > > + > > TDX guest code has already defined/uses "TDVMCALL_STATUS_RETRY", which is > > one > > of the TDG.VP.VMCALL Status Codes. > > > > IMHO, the style of the macros should be unified. > > How about using TDVMALL_STATUS_* for TDG.VP.VMCALL Status Codes? > > > > +/* > > + * TDG.VP.VMCALL Status Codes (returned in R10) > > + */ > > +#define TDVMCALL_STATUS_SUCCESS 0x0000000000000000ULL > > -#define TDVMCALL_STATUS_RETRY 1 > > +#define TDVMCALL_STATUS_RETRY 0x0000000000000001ULL > > +#define TDVMCALL_STATUS_INVALID_OPERAND 0x8000000000000000ULL > > Makes sense as they are the hardware status codes. I'll do a patch against the CoCo queue for the TDVMCALL_STATUS prefix FYI. Regards, Tony
