Ani Sinha <anisinha@xxxxxxxxxx> writes: >> On 28 Aug 2024, at 4:53 PM, Markus Armbruster <armbru@xxxxxxxxxx> wrote: >> >> Ani Sinha <anisinha@xxxxxxxxxx> writes: >> >>> error_report() is more appropriate for error situations. Replace fprintf with >>> error_report() and error_printf() as appropriate. Cosmetic. No functional >>> change. >> >> Uh, I missed this last time around: the change is more than just >> cosmetics! The error messages change, e.g. from >> >> $ qemu-system-x86_64 -nodefaults -S -display none --accel kvm >> qemu-system-x86_64: --accel kvm: Could not access KVM kernel module: Permission denied >> qemu-system-x86_64: --accel kvm: failed to initialize kvm: Permission denied >> >> to >> >> $ qemu-system-x86_64 -nodefaults -S -display none --accel kvm >> Could not access KVM kernel module: Permission denied >> qemu-system-x86_64: --accel kvm: failed to initialize kvm: Permission denied > > You got this backwards. This is what I have: I do! Sorry %-} [...]
