On Fri, Aug 16, 2024 at 10:55:50AM -0700, Jeff Johnson wrote: > On 8/15/24 08:11, Jason Gunthorpe wrote: > > This intends to have high coverage of the page table format functions and > > the IOMMU implementation itself, exercising the various corner cases. > > > > The kunit can be run in the kunit framework, using commands like: > > > > tools/testing/kunit/kunit.py run --build_dir build_kunit_arm64 --arch arm64 --make_options LD=ld.lld-18 --make_options 'CC=clang-18 --target=aarch64-linux-gnu' --kunitconfig ./drivers/iommu/generic_pt/.kunitconfig > > tools/testing/kunit/kunit.py run --build_dir build_kunit_uml --make_options CC=gcc-13 --kunitconfig ./drivers/iommu/generic_pt/.kunitconfig --kconfig_add CONFIG_WERROR=n > > tools/testing/kunit/kunit.py run --build_dir build_kunit_x86_64 --arch x86_64 --kunitconfig ./drivers/iommu/generic_pt/.kunitconfig > > tools/testing/kunit/kunit.py run --build_dir build_kunit_i386 --arch i386 --kunitconfig ./drivers/iommu/generic_pt/.kunitconfig > > tools/testing/kunit/kunit.py run --build_dir build_kunit_i386pae --arch i386 --kunitconfig ./drivers/iommu/generic_pt/.kunitconfig --kconfig_add CONFIG_X86_PAE=y > > > > There are several interesting corner cases on the 32 bit platforms that > > need checking. > > > > FIXME: further improve the tests > > > > Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx> > > --- > ... > > > +kunit_test_suites(&NS(iommu_suite)); > > + > > +MODULE_LICENSE("GPL"); > > +MODULE_IMPORT_NS(GENERIC_PT_IOMMU); > > Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the > description is missing"), a module without a MODULE_DESCRIPTION() will > result in a warning when built with make W=1. Recently, multiple > developers have been eradicating these warnings treewide, and very few > are left, so please don't introduce a new one :) Yep, I fixed them all Thanks, Jason