On 05/27, Michael S. Tsirkin wrote: > > On Thu, May 27, 2010 at 02:44:48PM +0200, Oleg Nesterov wrote: > > On 05/27, Michael S. Tsirkin wrote: > > > > > > On Tue, May 18, 2010 at 05:04:51PM -0700, Sridhar Samudrala wrote: > > > > Add a new kernel API to create a singlethread workqueue and attach it's > > > > task to current task's cgroup and cpumask. > > > > > > > > Signed-off-by: Sridhar Samudrala <sri@xxxxxxxxxx> > > > > > > Could someone familiar with workqueue code please comment on whether > > > this patch is suitable for 2.6.35? > > > > > > It is needed to fix the case where vhost user might cause a kernel > > > thread to consume more CPU than allowed by the cgroup. > > > Should I merge it through the vhost tree? > > > Ack for this? > > > > I don't understand the reasons for this patch, but this doesn't matter. > > Depending on userspace application, driver can create a lot of work > for a workqueue to handle. By making the workqueue thread > belong in a cgroup, we make it possible to the CPU and other > resources thus consumed. OK, I see, thanks for your explanation. in case I wasn't clear... I didn't mean I dislike this idea, only the the implementation of create_singlethread_workqueue_in_current_cg(), it doesn't belong to workqueue.c imho. Oleg. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
