> -----Original Message----- > From: Jason Gunthorpe <jgg@xxxxxxxxxx> > Sent: Friday, August 9, 2024 4:12 PM > To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@xxxxxxxxxx> > Cc: acpica-devel@xxxxxxxxxxxxxxx; Alex Williamson > <alex.williamson@xxxxxxxxxx>; Guohanjun (Hanjun Guo) > <guohanjun@xxxxxxxxxx>; iommu@xxxxxxxxxxxxxxx; Joerg Roedel > <joro@xxxxxxxxxx>; Kevin Tian <kevin.tian@xxxxxxxxx>; kvm@xxxxxxxxxxxxxxx; > Len Brown <lenb@xxxxxxxxxx>; linux-acpi@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>; Rafael J. > Wysocki <rafael@xxxxxxxxxx>; Robert Moore <robert.moore@xxxxxxxxx>; Robin > Murphy <robin.murphy@xxxxxxx>; Sudeep Holla <sudeep.holla@xxxxxxx>; > Will Deacon <will@xxxxxxxxxx>; Eric Auger <eric.auger@xxxxxxxxxx>; Jean- > Philippe Brucker <jean-philippe@xxxxxxxxxx>; Moritz Fischer <mdf@xxxxxxxxxx>; > Michael Shavit <mshavit@xxxxxxxxxx>; Nicolin Chen <nicolinc@xxxxxxxxxx>; > patches@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/8] iommu/arm-smmu-v3: Use S2FWB when available > > On Fri, Aug 09, 2024 at 02:26:13PM +0000, Shameerali Kolothum Thodi wrote: > > > + if (smmu->features & ARM_SMMU_FEAT_S2FWB) > > > + pgtbl_cfg.quirks |= IO_PGTABLE_QUIRK_ARM_S2FWB; > > > > This probably requires an update in arm_64_lpae_alloc_pgtable_s2() quirks > check. > > Yep, fixed I was hoping you had HW to test this.. Let me see if I can get hold of a test setup that supports S2FWB. I do have another concern with respect to the hardware we have which doesn't support S2FWB, but those can claim CANWBS. The problem is, BIOS update is not a very liked/feasible solution to already deployed ones. But we can probably add an option/quirk in SMMUv3 driver for those platforms(based on ACPI_IORT_SMMU_V3_HISILICON_HI161X). I hope this is fine. Thanks, Shameer
