Re: [PATCH 10/22] KVM: x86/mmu: Replace PFERR_NESTED_GUEST_PAGE with a more descriptive helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 10/22] KVM: x86/mmu: Replace PFERR_NESTED_GUEST_PAGE with a more descriptive helper
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Wed, 14 Aug 2024 19:32:08 +0200
Cc: kvm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Peter Gonda <pgonda@xxxxxxxxxx>, Michael Roth <michael.roth@xxxxxxx>, Vishal Annapurve <vannapurve@xxxxxxxxxx>, Ackerly Tng <ackerleytng@xxxxxxxxxx>
In-reply-to: <20240809190319.1710470-11-seanjc@google.com>
References: <20240809190319.1710470-1-seanjc@google.com> <20240809190319.1710470-11-seanjc@google.com>
User-agent: Mozilla Thunderbird

On 8/9/24 21:03, Sean Christopherson wrote:

-	if (direct &&
-	    (error_code & PFERR_NESTED_GUEST_PAGE) == PFERR_NESTED_GUEST_PAGE &&
+	if (direct && (is_write_to_guest_page_table(error_code)) &&


Too many parentheses. :)

Maybe put it before patch 3 if we decide not to Cc: stable? Or evensquash it in there?


Paolo

Follow-Ups:
- Re: [PATCH 10/22] KVM: x86/mmu: Replace PFERR_NESTED_GUEST_PAGE with a more descriptive helper
  - From: Sean Christopherson

References:
- [PATCH 00/22] KVM: x86: Fix multiple #PF RO infinite loop bugs
  - From: Sean Christopherson
- [PATCH 10/22] KVM: x86/mmu: Replace PFERR_NESTED_GUEST_PAGE with a more descriptive helper
  - From: Sean Christopherson

Prev by Date: Re: [PATCH 09/22] KVM: x86/mmu: Try "unprotect for retry" iff there are indirect SPs
Next by Date: Re: [PATCH 25/25] KVM: x86: Add CPUID bits missing from KVM_GET_SUPPORTED_CPUID
Previous by thread: [PATCH 10/22] KVM: x86/mmu: Replace PFERR_NESTED_GUEST_PAGE with a more descriptive helper
Next by thread: Re: [PATCH 10/22] KVM: x86/mmu: Replace PFERR_NESTED_GUEST_PAGE with a more descriptive helper
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]