On Fri, Aug 09, 2024 at 07:34:20PM +0100, Robin Murphy wrote: > > However, the above was matching how the driver already worked (ie the > > old arm_smmu_enable_nesting()) where just asking for a normal S2 was > > gated only by FEAT_S2. > > Ohhhh, I see, so actually the same old subtlety is still there - > ALLOC_NEST_PARENT isn't a definite "allocate the parent domain for my nested > setup", it's "allocate a domain which will be capable of being upgraded to > nesting later *if* I choose to do so". Yes. All PAGING type domains are expected to be able to be attached nakedly without creating the DOMAIN_NESTED. > Is the intent that someone could still use this if they had no > intention of nesting but just wanted to ensure S2 format for their > single stage of translation for some reason? Sort of, yes.. When booting a VM with DMA default to bypass there are two flows for the time before the vIOMMU is enabled. The first flow is to allocate the S2 NESTING_PARENT and attach it directly to the RID. This is a normal S2 paging domain. The VMM would later switch to a DOMAIN_NESTED (maybe with bypass) when the vIOMMU is enabled by the VM and the vSTEs are parsed. The second flow, which is probably going to be the better way, is the VMM will create a DOMAIN_NESTED with a bypass vSTE and attach that instead of directly attaching the S2. When we worked through VIOMMU it turned out we always want the DOMAIN_NESTED to be the attached domain and the bypass/abort cases are handled through vSTE settings instead of naked domains. This allows the VIOMMU object to always be associated with the SID which is how we will link the event queues, the VMID and so on. > It remains somewhat confusing since S2 domains on S2-only SMMUs are > still fundamentally incapable of ever becoming a nested parent, but > admittedly I'm struggling to think of a name which would be more > accurate while still generic, so maybe it's OK... I think for now we can block it, as we know no use case to request NESTING_PARENT without intending to go on and create a DOMAIN_NESTED. Someday we may want to allow userspace to specify the page table parameters more exactly and that might be a good API to also force a S2 if someone has a (performance?) use case for S2 outside of nesting. Jason
