Re: [PATCH 09/25] KVM: TDX: Get system-wide info about TDX module on initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






On 8/13/2024 6:48 AM, Rick Edgecombe wrote:
From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>

TDX KVM needs system-wide information about the TDX module, store it in
struct tdx_info.  Release the allocated memory on module unloading by
hardware_unsetup() callback.

It seems the shortlog and changelog are stale or mismatched.


Signed-off-by: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
Signed-off-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>
Reviewed-by: Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx>
---
uAPI breakout v1:
  - Mention about hardware_unsetup(). (Binbin)
  - Added Reviewed-by. (Binbin)
  - Eliminated tdx_md_read(). (Kai)
  - Include "x86_ops.h" to tdx.c as the patch to initialize TDX module
    doesn't include it anymore.
  - Introduce tdx_vm_ioctl() as the first tdx func in x86_ops.h

v19:
  - Added features0
  - Use tdx_sys_metadata_read()
  - Fix error recovery path by Yuan

Change v18:
  - Newly Added
---
  arch/x86/include/uapi/asm/kvm.h | 28 +++++++++++++
  arch/x86/kvm/vmx/tdx.c          | 70 +++++++++++++++++++++++++++++++++
  2 files changed, 98 insertions(+)

[...]
+
  #endif /* _ASM_X86_KVM_H */
diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
index de14e80d8f3a..90b44ebaf864 100644
--- a/arch/x86/kvm/vmx/tdx.c
+++ b/arch/x86/kvm/vmx/tdx.c
@@ -3,6 +3,7 @@
  #include <asm/tdx.h>
  #include "capabilities.h"
  #include "x86_ops.h"
+#include "mmu.h"

Is this needed by this patch?


  #include "tdx.h"
#undef pr_fmt
@@ -30,6 +31,72 @@ static void __used tdx_guest_keyid_free(int keyid)
  	ida_free(&tdx_guest_keyid_pool, keyid);
  }
[...]




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux