On Mon, Aug 05, 2024 at 06:15:51PM +0200, Paolo Bonzini wrote: > On Mon, Aug 5, 2024 at 5:39 PM Michael Roth <michael.roth@xxxxxxx> wrote: > > > (And is there any user of query-sev-attestation-report for > > > non-SNP?) > > > > No, this would have always returned error, either via KVM, or via > > firmware failure. > > I mean for *non-SNP*. If no one ever used it, we can deprecate the command. This would have been the main architectured way to fetch an attestation report from firmware for non-SNP cases, so I think it's likely being used to some degree. Libvirt itself does not seem to use it directly, however (opting for the less verbose query-sev-launch-measure), but it seems likely there would be SEV deployments that do. libvirt might find other bits like policy/major/minor/etc. to be redundant since it also controls the guest config, but maybe 3rd party tools prefer to known those values as provided by firmware so they can ensure they match expected values. -Mike > > Paolo >
