Re: [PATCH v2] docs: KVM: Fix register ID of SPSR_FIQ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+Cc kvmarm people and the list ...

On 2023/6/6 23:46, Takahiro Itazuri wrote:
Fixes the register ID of SPSR_FIQ.

SPSR_FIQ is a 64-bit register and the 64-bit register size mask is
0x0030000000000000ULL.

Fixes: fd3bc912d3d1 ("KVM: Documentation: Document arm64 core registers in detail")
Signed-off-by: Takahiro Itazuri <itazur@xxxxxxxxxx>

... since you're fixing the encoding of an *arm64* core register and the
mentioned commit fd3bc912d3d1 was merged via the kvmarm tree. I guess
this is the main reason why this patch has been blocked on the list for
over a year, as pointed out recently by Alexander [*].


---
Changes from v1
- Add a description about the 64-bit register size mask in the commit
  message.
- Link: https://lore.kernel.org/all/20230410121927.26953-1-itazur@xxxxxxxxxx/

---
 Documentation/virt/kvm/api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
index a5c803f39832..65dad2581751 100644
--- a/Documentation/virt/kvm/api.rst
+++ b/Documentation/virt/kvm/api.rst
@@ -2535,7 +2535,7 @@ Specifically:
   0x6030 0000 0010 004a SPSR_ABT    64  spsr[KVM_SPSR_ABT]
   0x6030 0000 0010 004c SPSR_UND    64  spsr[KVM_SPSR_UND]
   0x6030 0000 0010 004e SPSR_IRQ    64  spsr[KVM_SPSR_IRQ]
-  0x6060 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
+  0x6030 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
   0x6040 0000 0010 0054 V0         128  fp_regs.vregs[0]    [1]_
   0x6040 0000 0010 0058 V1         128  fp_regs.vregs[1]    [1]_
   ...

The change itself looks reasonable.

Thanks,
Zenghui

[*] https://lore.kernel.org/all/20240802132036.914457-1-glider@xxxxxxxxxx




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux