Daniel P. Berrangé <berrange@xxxxxxxxxx> writes: > On Tue, Jul 30, 2024 at 02:26:49PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé <berrange@xxxxxxxxxx> writes: >> >> > On Tue, Jul 30, 2024 at 10:10:25AM +0200, Markus Armbruster wrote: >> >> QAPI's 'prefix' feature can make the connection between enumeration >> >> type and its constants less than obvious. It's best used with >> >> restraint. >> >> >> >> QCryptoHashAlgorithm has a 'prefix' that overrides the generated >> >> enumeration constants' prefix to QCRYPTO_HASH_ALG. >> >> >> >> We could simply drop 'prefix', but then the prefix becomes >> >> QCRYPTO_HASH_ALGORITHM, which is rather long. >> >> >> >> We could additionally rename the type to QCryptoHashAlg, but I think >> >> the abbreviation "alg" is less than clear. >> > >> > I would have gone with this, but it is a bit of a bike shed colouring >> > debate so I'm not fussed >> >> Either solution seems okay, so I went with my personal preference. Do >> feel free to state yours and ask me to respin! > > After reviewing the patches that follow, I'd observe that picking > Algo has made the following patches much larger than if it had > stuck with Alg. Basically changing both the types & constants, > instead of only having to change the types. Yes. Worth the more obvious names to me, but again, feel free to ask me to respin for less churn.
