Re: [kvm-unit-tests PATCH 1/4] s390x: Split snippet makefile rules into new file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/25/24 4:27 PM, Christoph Schlameuss wrote:
On Thu, 18 Jul 2024 10:50:16 +0000
Janosch Frank <frankja@xxxxxxxxxxxxx> wrote:

It's time to move the snippet related Makefile parts into a new file
to make s390x/Makefile less busy.

Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
---
  s390x/Makefile          | 34 ++++------------------------------
  s390x/snippets/Makefile | 30 ++++++++++++++++++++++++++++++
  2 files changed, 34 insertions(+), 30 deletions(-)
  create mode 100644 s390x/snippets/Makefile

IMHO the commit message should start with "s390x/Makefile: Split snippet
makefile rules into new file" for more consistency.

With that fixed:
Reviewed-by: Christoph Schlameuss <schlameuss@xxxxxxxxxxxxx>

Sure
I'll send a new version around anyway, since I've rebased the series on Marc's make file patch.




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux