>-----Original Message----- >From: Shirley Ma [mailto:mashirle@xxxxxxxxxx] >Sent: Tuesday, May 25, 2010 10:16 AM >To: Kirsher, Jeffrey T >Cc: Rose, Gregory V; davem@xxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; >netdev@xxxxxxxxxxxxxxx; e1000-devel@xxxxxxxxxxxxxxxxxxxxx >Subject: Re: [PATCH net-next] ixgbe: make macvlan on PF working when >SRIOV is enabled > >To produce this problem: > >1. modprobe ixgbe max_vfs=2 > eth4 is PF, eth5 is VF >2. ip link set eth4 up >3. ip link add link eth4 address 54:52:00:35:e3:20 macvlan2 type macvlan >4. ip addr add 192.168.7.74/24 dev macvlan2 >5. ping macvlan2 from remote host, works >6. ip link set eth5 up >7. ping macvlan2 from remote host failed. > >Based on my understanding, the problem is: >1. PF set_rar use rar index is 0, and vmdq index is adapter->num_vfs, >2. when macvlan2 is created, rar index is based rar_used_count, which >would be 1. >3. later when VF is up, the rar index is vf+1, and vmdq index is vf, so >VF0 will overwrite macvlan2 rar entry. > >The fix here: >1. make sure PF uses vmdq index = adapter->num_vfs during >initialization, reset. >2. reserve rar index for all VFs from 1 to num_vfs + 1. > > >Please let me know whether my understanding is correct or not. Yes, that appears to be correct. We'll test your patch but I think you're on the right track. - Greg ��.n��������+%������w��{.n�����o�^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�