On 7/30/24 22:00, Sean Christopherson wrote:
The probability of guest_memfd not having struct page for mapped pfns is likely very low, but at the same time, providing a pfn+page pair doesn't cost us much. And if it turns out that not having struct page is nonsensical, deferring the kvm_gmem_get_pfn() => kvm_gmem_get_page() conversion could be annoying, but highly unlikely to be painful since it should be 100% mechanical. Whereas reverting back to kvm_gmem_get_pfn() if we make the wrong decision now could mean doing surgery on a pile of arch code.
Ok, fair enough. The conflict resolution is trivial either way (I also checked the TDX series and miraculously it has only one conflict which is also trivial).
Paolo
