On Tue, Jul 30, 2024 at 10:10:32AM +0200, Markus Armbruster wrote: > QAPI's 'prefix' feature can make the connection between enumeration > type and its constants less than obvious. It's best used with > restraint. > > QCryptodevBackendAlgType a 'prefix' that overrides the generated > enumeration constants' prefix to QCRYPTODEV_BACKEND_ALG. > > We could simply drop 'prefix', but I think the abbreviation "alg" is > less than clear. > > Additionally rename the type to QCryptodevBackendAlgoType. The prefix > becomes QCRYPTODEV_BACKEND_ALGO_TYPE. > > Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx> > --- > qapi/cryptodev.json | 5 ++--- > include/sysemu/cryptodev.h | 2 +- > backends/cryptodev-builtin.c | 6 +++--- > backends/cryptodev-lkcf.c | 4 ++-- > backends/cryptodev.c | 6 +++--- > hw/virtio/virtio-crypto.c | 14 +++++++------- > 6 files changed, 18 insertions(+), 19 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
