On Mon, Jul 29, 2024 at 6:34 AM Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote:
>
> On Fri, Jul 26, 2024 at 09:44:30AM -0400, Cleber Rosa wrote:
> > The tests under machine_aarch64_virt.py and machine_aarch64_sbsaref.py
> > should not be writing to the ISO files. By adding "media=cdrom" the
> > "ro" is autmatically set.
> >
> > While at it, let's use a single code style and hash for the ISO url.
> >
> > Signed-off-by: Cleber Rosa <crosa@xxxxxxxxxx>
> > ---
> > tests/avocado/machine_aarch64_sbsaref.py | 6 +++++-
> > tests/avocado/machine_aarch64_virt.py | 14 +++++++-------
> > 2 files changed, 12 insertions(+), 8 deletions(-)
> >
> > diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py
> > index e920bbf08c..1275f24532 100644
> > --- a/tests/avocado/machine_aarch64_sbsaref.py
> > +++ b/tests/avocado/machine_aarch64_sbsaref.py
> > @@ -129,7 +129,11 @@ def boot_alpine_linux(self, cpu):
> > "-cpu",
> > cpu,
> > "-drive",
> > - f"file={iso_path},format=raw",
> > + f"file={iso_path},media=cdrom,format=raw",
> > + "-device",
> > + "virtio-rng-pci,rng=rng0",
> > + "-object",
> > + "rng-random,id=rng0,filename=/dev/urandom",
> > )
>
> The commit message doesn't say anything about adding virtio-rng.
> If that's needed for some reason, do it as a separate commit
> with an explanation of the bug its fixing.
>
This is actually a rebase mistake. virtio-rng was removed in 21f123f3c.
I'll fix it in a v2.
Thanks for spotting it,
- Cleber.
