[bug report] KVM: SEV: Provide support for SNP_GUEST_REQUEST NAE event

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

Hello Brijesh Singh,

Commit 88caf544c930 ("KVM: SEV: Provide support for SNP_GUEST_REQUEST
NAE event") from Jul 1, 2024 (linux-next), leads to the following
Smatch static checker warning:

	arch/x86/kvm/svm/sev.c:454 __sev_guest_init()
	warn: missing error code here? 'snp_guest_req_init()' failed.

arch/x86/kvm/svm/sev.c
    443         ret = sev_asid_new(sev);
    444         if (ret)
    445                 goto e_no_asid;
    446 
    447         init_args.probe = false;
    448         ret = sev_platform_init(&init_args);
    449         if (ret)
    450                 goto e_free;
    451 
    452         /* This needs to happen after SEV/SNP firmware initialization. */
    453         if (vm_type == KVM_X86_SNP_VM && snp_guest_req_init(kvm))
--> 454                 goto e_free;

This feels like we should propogate the error code from snp_guest_req_init()
instead of returning success.

    455 
    456         INIT_LIST_HEAD(&sev->regions_list);
    457         INIT_LIST_HEAD(&sev->mirror_vms);
    458         sev->need_init = false;
    459 
    460         kvm_set_apicv_inhibit(kvm, APICV_INHIBIT_REASON_SEV);
    461 
    462         return 0;
    463 
    464 e_free:
    465         argp->error = init_args.error;
    466         sev_asid_free(sev);
    467         sev->asid = 0;
    468 e_no_asid:
    469         sev->vmsa_features = 0;
    470         sev->es_active = false;
    471         sev->active = false;
    472         return ret;
    473 }

regards,
dan carpenter