On Tue, 16 Jul 2024 at 09:28, Akihiko Odaki <akihiko.odaki@xxxxxxxxxx> wrote:
>
> hvf currently does not support PMU.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@xxxxxxxxxx>
> ---
> target/arm/cpu.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/arm/cpu.c b/target/arm/cpu.c
> index 8c180c679ce2..9e1d15701468 100644
> --- a/target/arm/cpu.c
> +++ b/target/arm/cpu.c
> @@ -1603,6 +1603,10 @@ static void arm_set_pmu(Object *obj, bool value, Error **errp)
> }
>
> if (value) {
> + if (hvf_enabled()) {
> + error_setg(errp, "'pmu' feature not suported by hvf");
> + return;
> + }
> if (kvm_enabled() && !kvm_arm_pmu_supported()) {
> error_setg(errp, "'pmu' feature not supported by KVM on this host");
> return;
Typo (should be "supported") but otherwise
Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
thanks
-- PMM
