On Tue, 2024-07-09 at 15:38 -0700, Rick Edgecombe wrote: > > Could we move them to tdp_mmu.c and rename them to something like > > tdp_mmu_type_to_root() and tdp_mmu_fault_to_root() ? > > tdp_mmu_get_root_for_fault() was proposed by Paolo, and tdp_mmu_get_root() was > discussed without comment. Not to say there is anything wrong with the names > proposed, but I think this is wading into bikeshedding territory at this > stage. I kept thinking about this comment. On more consideration tdp_mmu_get_root() is a problematically terrible name since "get" usually means take a reference to something which is something you can do to roots and (and what kvm_tdp_mmu_get_root() is doing). So people might think tdp_mmu_get_root() is taking a reference.
