Avi Kivity wrote: > On 05/24/2010 05:03 AM, Xiao Guangrong wrote: >> >> Avi Kivity wrote: >> >> >>>> + if (need_unsync) >>>> + kvm_unsync_pages(vcpu, gfn); >>>> return 0; >>>> } >>>> >>>> >>>> >>> Looks good, I'm just uncertain about role.invalid handling. What's the >>> reasoning here? >>> >>> >> Avi, >> >> Thanks for your reply. >> >> We no need worry about 'role.invalid' here, since we only allow the >> PTE shadow >> pages(role.level == 1) become unsync, and in current code, >> 'role.invalid' is only >> used for root shadow pages. >> > > Right, the invlpg change is not it yet. But I think it should be in > this patch; I don't like subtle dependencies, and it will make the > invplg patch simpler. > OK, i'll fix those two patches, thanks -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
