If you know that the test will fail without special command line parameters when accel is TCG, then I think what you are suggesting looks correct to me: the original test is skipped if KVM is not present, and when run under TCG, the correct parameters are passed to QEMU. Thanks, Alex > > Signed-off-by: Alex Bennée <alex.bennee@xxxxxxxxxx> > > 1 file changed, 8 insertions(+) > arm/unittests.cfg | 8 ++++++++ > > modified arm/unittests.cfg > @@ -52,8 +52,16 @@ extra_params = -append 'cycle-counter 0' > file = pmu.flat > groups = pmu > arch = arm64 > +accel = kvm > extra_params = -append 'pmu-event-introspection' > > +[pmu-event-introspection-icount] > +file = pmu.flat > +groups = pmu > +arch = arm64 > +accel = tcg > +extra_params = -icount shift=1 -append 'pmu-event-introspection' > + > [pmu-event-counter-config] > file = pmu.flat > groups = pmu > --8<---------------cut here---------------end--------------->8--- > > which just punts icount on TCG to its own test (note there are commented > out versions further down the unitests.cfg file) > > -- > Alex Bennée > Virtualisation Tech Lead @ Linaro
