On 6/28/2024 9:22 AM, Borislav Petkov wrote: > On Fri, Jun 21, 2024 at 06:08:46PM +0530, Nikunj A Dadhania wrote: >> Currently, SEV guest driver retrieves the pointers to VMPCK and >> os_area_msg_seqno from the secrets page. In order to get rid of this >> dependency, > > And we do this because...? Thinking more about this patch, I think I can drop this patch and retain the VMPCK pointer and the os_area_msg_seqno. In my v8 [1] and earlier series, I had dropped secrets pages pointer from snp_guest_dev structure. But with newer changes in v9 secrets pages pointer is retained so all these APIs will still be fine. > >> use vmpck_id to index the appropriate key and the corresponding >> message sequence number. >> >> Signed-off-by: Nikunj A Dadhania <nikunj@xxxxxxx> Regards Nikunj 1. https://lore.kernel.org/lkml/20240215113128.275608-8-nikunj@xxxxxxx/