On Thu, 2024-06-20 at 16:44 +0800, Binbin Wu wrote: > > TDX MMU support will exclude certain MMU operations, so only plug in the > > mirroring x86 ops where they will be needed. For zapping/freeing, only > > hook tdp_mmu_iter_set_spte() which is use used for mapping and linking > ^ > extra "use" > > Also, this sentence is a bit confusing about "used for mapping and linking". Yes. Is this more clear? "...tdp_mmu_iter_set_spte(), which is use used for setting leaf PTEs and linking non-leaf PTEs." > > > PTs. Don't bother hooking tdp_mmu_set_spte_atomic() as it is only used for > > zapping PTEs in operations unsupported by TDX: zapping collapsible PTEs and > > kvm_mmu_zap_all_fast(). > > > > In previous changes to address races around concurrent populating using > > tdp_mmu_set_spte_atomic(), a solution was introduced to temporarily set > > REMOVED_SPTE in the mirrored page tables while performing the external > ^ > FROZEN_SPTE Oops. And agreed on the other nits. Thanks.
