On 2024-06-21 06:26:19+0000, Michael S. Tsirkin wrote: > On Mon, May 27, 2024 at 08:27:49AM +0200, Thomas Weißschuh wrote: <snip> > > diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c > > index 1540e9091a45..a4982cc5928e 100644 > > --- a/hw/misc/pvpanic.c > > +++ b/hw/misc/pvpanic.c > > @@ -21,13 +21,12 @@ > > #include "hw/qdev-properties.h" > > #include "hw/misc/pvpanic.h" > > #include "qom/object.h" > > -#include "standard-headers/linux/pvpanic.h" > > > This part is wrong. PVPANIC_PANICKED and PVPANIC_CRASH_LOADED > are still used in pvpanic.c directly, so we should > include standard-headers/linux/pvpanic.h to avoid depending > on which header includes which. Ack. > I fixed up the patch. Thanks! <snip> Thomas
