Re: [KVM-AUTOTEST PATCH] KVM test: use command line option wrapper functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2010-05-20 at 12:50 +0300, Michael Goldish wrote:
> On 05/19/2010 11:25 AM, Feng Yang wrote:
> > Hi, Michael
> > 
> > Thanks for your patch.
> > We plan add "netdev" parameter support in make_qemu_command.  Since you are working on this part. Could you add netdev support in your patch? hopeful netdev can be default supported in make_qemu_command if qemu support it. Thanks very much!
> 
> Sure, I'll look into it.
> 
> > I think the point of this patch is good and we need this kinds of patch.
> > But I think we need not add so many new function.  Especially some function only directly return the string and do nothing more.
> > This will increase the function call consumption.
> > 
> All these helper functions are meant to be extended and modified in the
> future.  They're only there to minimize future effort involved in adding
> support for new command line syntaxes.
> Right now add_smp() just returns " -smp %s", but in the future we may
> have to support different syntaxes for -smp, and then add_smp() will
> consult the output of 'qemu -help' and return the proper string.
> What do you mean by function call consumption?  I don't think these
> functions cause a measurable slowdown, and make_qemu_command() is called
> very few times, so this really isn't a concern IMO.

Agreed, the wrappers are a good strategy in the case we have to support
different feature sets and syntax.


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux