On Wed, Jun 12, 2024, Dev Jain wrote: > > On 6/12/24 16:14, Muhammad Usama Anjum wrote: > > > > > > diff --git a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c > > index 4f5881d4ef66d..695c45635d257 100644 > > --- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c > > +++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c > > @@ -144,10 +144,9 @@ int main(int argc, char *argv[]) > > free((void *)hv_cpuid_entries); > > if (!kvm_cpu_has(X86_FEATURE_VMX) || > > - !kvm_has_cap(KVM_CAP_HYPERV_ENLIGHTENED_VMCS)) { > > - print_skip("Enlightened VMCS is unsupported"); > > - goto do_sys; > > - } > > + !kvm_has_cap(KVM_CAP_HYPERV_ENLIGHTENED_VMCS)) > > + ksft_exit_skip("Enlightened VMCS is unsupported\n"); > > + > > Isn't it incorrect to delete 'goto do_sys'? ksft_exit_skip() will exit and the > program will never jump to that label. At other places too you have deleted the 'goto'. Ya, exiting instead of continuing on will break these tests.