On Wed, Jun 05, 2024 at 10:29:53AM +0100, Steven Price wrote: > --- /dev/null > +++ b/arch/arm64/include/asm/rsi_cmds.h > @@ -0,0 +1,47 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (C) 2023 ARM Ltd. > + */ > + > +#ifndef __ASM_RSI_CMDS_H > +#define __ASM_RSI_CMDS_H [...] > --- /dev/null > +++ b/arch/arm64/include/asm/rsi_smc.h > @@ -0,0 +1,142 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (C) 2023 ARM Ltd. > + */ > + > +#ifndef __SMC_RSI_H_ > +#define __SMC_RSI_H_ A small nitpick if you respin some patches - please make the header guards consistent. We tend to to use the top variant above, so the rsi_smc.h would be __ASM_RSI_SMC_H. The same throughout this series. -- Catalin
