On Sat, 2024-06-08 at 11:15 +0200, Paolo Bonzini wrote: > > Agree 'process' sticks out. Somehow having attr_filter and args.attributes > > in > > the same struct feels a bit wrong. Not that process was a lot better. > > > > I guess attr_filter is more about alias ranges, and args.attribute is more > > about > > conversion to various types of memory (private, shared and ideas of other > > types > > I guess). But since today we only have private and shared, I wonder if there > > is > > some way to combine them within struct kvm_gfn_range? I've not thought this > > all > > the way through. > > I think it's better that they stay separate. One is an argument > (args.attribute), the other is not, it should be clear enough. Ok, yea. Looking at this more, it makes sense.