On Fri, Jun 7, 2024 at 8:39 PM Edgecombe, Rick P <rick.p.edgecombe@xxxxxxxxx> wrote: > > > + return kvm_gfn_direct_mask(kvm); > > > > Ok, please excuse me again for being fussy on the naming. Typically I > > think of a "mask" as something that you check against, or something > > that you do x &~ mask, not as something that you add. Maybe > > kvm_gfn_root_offset and gfn_direct_offset? > > As for the name, I guess I'd be less keen on "offset" because it's not clear > that it is a power-of-two value that can be used with bitwise operations. > > I'm not sure what the "fixed" adds and it makes it longer. Also, many PTE bits > cannot be moved and they are not referred to as fixed, where the shared bit > actually *can* be moved via GPAW (not that the MMU code cares about that > though). > > Just "bits" sounds better to me, so maybe I'll try? > kvm_gfn_direct_bits() > kvm_gfn_root_bits() Yep, kvm_gfn_direct_bits and kvm_gfn_root_bits are good. Paolo
