Re: [PATCH v2 09/15] KVM: x86/tdp_mmu: Support mirror root for TDP MMU

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 09/15] KVM: x86/tdp_mmu: Support mirror root for TDP MMU
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Fri, 7 Jun 2024 10:27:29 +0200
Cc: "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "seanjc@xxxxxxxxxx" <seanjc@xxxxxxxxxx>, "Huang, Kai" <kai.huang@xxxxxxxxx>, "sagis@xxxxxxxxxx" <sagis@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "Zhao, Yan Y" <yan.y.zhao@xxxxxxxxx>, "Aktas, Erdem" <erdemaktas@xxxxxxxxxx>, "dmatlack@xxxxxxxxxx" <dmatlack@xxxxxxxxxx>, "Yamahata, Isaku" <isaku.yamahata@xxxxxxxxx>, "isaku.yamahata@xxxxxxxxx" <isaku.yamahata@xxxxxxxxx>
In-reply-to: <643a2ae1c0e894a4dd623dfe8c8f7ca5eb897ce6.camel@intel.com>
References: <20240530210714.364118-1-rick.p.edgecombe@intel.com> <20240530210714.364118-10-rick.p.edgecombe@intel.com> <643a2ae1c0e894a4dd623dfe8c8f7ca5eb897ce6.camel@intel.com>

On Fri, May 31, 2024 at 12:01 AM Edgecombe, Rick P
<rick.p.edgecombe@xxxxxxxxx> wrote:
>
> On Thu, 2024-05-30 at 14:07 -0700, Rick Edgecombe wrote:
> >
> > Update handle_changed_spte() to take a role. Use this for a KVM_BUG_ON().
>
> I'm wondering if the KVM_BUG_ON() is not worth the cost to the diffstat.

Agreed, it seems like pointless churn.

Paolo

References:
- [PATCH v2 00/15] TDX MMU prep series part 1
  - From: Rick Edgecombe
- [PATCH v2 09/15] KVM: x86/tdp_mmu: Support mirror root for TDP MMU
  - From: Rick Edgecombe
- Re: [PATCH v2 09/15] KVM: x86/tdp_mmu: Support mirror root for TDP MMU
  - From: Edgecombe, Rick P

Prev by Date: Re: [PATCH v2 08/15] KVM: x86/tdp_mmu: Introduce KVM MMU root types to specify page table type
Next by Date: Re: [PATCH v2 09/15] KVM: x86/tdp_mmu: Support mirror root for TDP MMU
Previous by thread: Re: [PATCH v2 09/15] KVM: x86/tdp_mmu: Support mirror root for TDP MMU
Next by thread: Re: [PATCH v2 09/15] KVM: x86/tdp_mmu: Support mirror root for TDP MMU
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]