On Wed, May 22, 2024, Xiaoyao Li wrote: > On 5/21/2024 1:59 AM, Sean Christopherson wrote: > > +#define VMX_MISC_ACTIVITY_SHUTDOWN BIT_ULL(7) > > Same as Patch 4. It is newly added but will be used by following patch 10. > > Call out it in change log or move it to patch 10. This one actually is mentioned, though it's not super obvious. Opportunistically use BIT_ULL() instead of open coding hex values, add defines for feature bits that are architecturally defined, and move the ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ defines down in the file so that they are colocated with the helpers for getting fields from VMX_MISC.