Re: [RFC kvm-unit-tests PATCH] build: fix .aux.o target building

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 05, 2024 at 06:16 PM +1000, Nicholas Piggin <npiggin@xxxxxxxxx> wrote:
> Here's another oddity I ran into with the build system. Try run make
> twice. With arm64 and ppc64, the first time it removes some intermediate
> files and the second causes another rebuild of several files. After
> that it's fine. s390x seems to follow a similar pattern but does not
> suffer from the problem. Also, the .PRECIOUS directive is not preventing
> them from being deleted inthe first place. So... that probably means I
> haven't understood it properly and the fix may not be correct, but it
> does appear to DTRT... Anybody with some good Makefile knowledge might
> have a better idea.
>

$ make clean -j &>/dev/null && make -d
…
Successfully remade target file 'all'.
Removing intermediate files...
rm powerpc/emulator.aux.o powerpc/tm.aux.o powerpc/spapr_hcall.aux.o powerpc/interrupts.aux.o powerpc/selftest.aux.o powerpc/smp.aux.o powerpc/selftest-migration.aux.o powerpc/spapr_vpa.aux.o powerpc/sprs.aux.o powerpc/rtas.aux.o powerpc/memory-verify.aux.o

So an easier fix would be to add %.aux.o to .PRECIOUS (but that’s probably still not clean).

.PRECIOUS: %.o %.aux.o

Fixed the issue (I’ve tested on ppc64 only).

>
>
-- 
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux