On Mon, Jun 3, 2024 at 2:02 PM Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote: > > On Thu, May 30, 2024 at 06:16:19AM -0500, Pankaj Gupta wrote: > > > +# @policy: the 'POLICY' parameter to the SNP_LAUNCH_START command, as > > +# defined in the SEV-SNP firmware ABI (default: 0x30000) > > +# > > +# @guest-visible-workarounds: 16-byte, base64-encoded blob to report > > +# hypervisor-defined workarounds, corresponding to the 'GOSVW' > > +# parameter of the SNP_LAUNCH_START command defined in the SEV-SNP > > +# firmware ABI (default: all-zero) > > +# > > +# @id-block: 96-byte, base64-encoded blob to provide the 'ID Block' > > +# structure for the SNP_LAUNCH_FINISH command defined in the > > +# SEV-SNP firmware ABI (default: all-zero) > > +# > > +# @id-auth: 4096-byte, base64-encoded blob to provide the 'ID > > +# Authentication Information Structure' for the SNP_LAUNCH_FINISH > > +# command defined in the SEV-SNP firmware ABI (default: all-zero) > > +# > > +# @auth-key-enabled: true if 'id-auth' blob contains the 'AUTHOR_KEY' > > +# field defined SEV-SNP firmware ABI (default: false) > > In 'id-auth', 'auth' is short for 'authentication' > > In 'auth-key-enabled', 'auth' is short for 'author'. > > Shortening 'authentication' is a compelling win. Shorting 'author' > is not much of a win. > > So to make it less ambiguous, how about '@author-key-enabled' for > the field ? Good idea. Paolo
