Re: [PATCH v4 07/31] i386/sev: Introduce 'sev-snp-guest' object

[Paolo Bonzini <pbonzini@xxxxxxxxxx>]

On Thu, May 30, 2024 at 1:17 PM Pankaj Gupta <pankaj.gupta@xxxxxxx> wrote:
> +++ b/qapi/qom.json
> @@ -928,6 +928,61 @@
>              '*policy': 'uint32',
>              '*handle': 'uint32',
>              '*legacy-vm-type': 'bool' } }

Nit, missing empty line here.

> +##
> +# @SevSnpGuestProperties:
> +#


[...]

> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index c141f4fed4..841b45f59b 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -42,6 +42,7 @@
>
>  OBJECT_DECLARE_TYPE(SevCommonState, SevCommonStateClass, SEV_COMMON)
>  OBJECT_DECLARE_TYPE(SevGuestState, SevGuestStateClass, SEV_GUEST)
> +OBJECT_DECLARE_TYPE(SevSnpGuestState, SevSnpGuestStateClass, SEV_SNP_GUEST)

This separate struct is also unnecessary.

Paolo