On Thu, May 16, 2024 at 4:11 AM Huang, Kai <kai.huang@xxxxxxxxx> wrote: > > > >>>> + gfn_t raw_gfn; > >>>> + bool is_private = fault->is_private && kvm_gfn_shared_mask(kvm); > >>> > >>> Ditto. I wish we can have 'has_mirrored_private_pt'. > >> > >> Which name do you prefer? has_mirrored_pt or has_mirrored_private_pt? > > > > Why not helpers that wrap vm_type like: > > https://lore.kernel.org/kvm/d4c96caffd2633a70a140861d91794cdb54c7655.camel@xxxxxxxxx/ > > I am fine with any of them -- boolean (with either name) or helper. Helpers are fine. Paolo
