Re: [Qemu-devel] Re: KVM call agenda for May 18

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/18/2010 09:55 AM, Daniel P. Berrange wrote:
On Tue, May 18, 2010 at 09:34:06AM -0500, Anthony Liguori wrote:
On 05/18/2010 09:09 AM, Daniel P. Berrange wrote:
On Tue, May 18, 2010 at 08:53:19AM -0500, Anthony Liguori wrote:

On 05/17/2010 10:23 PM, Chris Wright wrote:

Please send in any agenda items you are interested in covering.

If we have a lack of agenda items I'll cancel the week's call.


- Slipping 0.13 release out to July 1st.

What is the plan wrt QMP and 0.13 ? Is the intention to have 100%[1] of the
existing monitor commands converted to QMP?
No.  I don't think our goal is to ever fully convert monitor commands to
QMP.  Some commands simply don't make sense as QMP commands (like x and xp).
We're a really long way from a complete conversion even  ignoring
commands which don't make sense in QMP. The current state almost
covers the commands libvirt currently uses, but there's much more
beyond that.

Is there a set of commands that you think need to be converted that
currently aren't?
Notable outstanding commands that libvirt has a non-negligable
chance of wanting to use in the not too distant future

  - blockdev_add/del (to replace drive_add/del)
  - commit/delvm/loadvm/savevm
  - screendump
  - set_link
  - mouse_{move,button,set}
  - sendkey
  - acl_{add,remove,policy,reset,show}
  - boot_set
  - watchdog_action


The full list of unconverted commands though is much long:

Thanks.  A lot of these should be easy to convert.

   $ grep cmd qemu-monitor.hx  | grep -v cmd_new | grep -v async
         .mhandler.cmd = do_help_cmd,
We don't need this.
         .mhandler.cmd = do_commit,
         .mhandler.cmd = do_logfile,
         .mhandler.cmd = do_log,

I think we can skip log and logfile.

         .mhandler.cmd = do_savevm,
         .mhandler.cmd = do_loadvm,
         .mhandler.cmd = do_delvm,
         .mhandler.cmd = do_singlestep,
         .mhandler.cmd = do_gdbserver,
         .mhandler.cmd = do_memory_dump,
         .mhandler.cmd = do_physical_memory_dump,

I'd prefer to skip the memory dump commands.
         .mhandler.cmd = do_print,
We can skip this.
         .mhandler.cmd = do_ioport_read,
         .mhandler.cmd = do_ioport_write,
         .mhandler.cmd = do_sendkey,
         .mhandler.cmd = do_sum,
We can skip do_sum.
         .mhandler.cmd = do_usb_add,
         .mhandler.cmd = do_usb_del,
         .mhandler.cmd = do_mouse_move,
         .mhandler.cmd = do_mouse_button,
         .mhandler.cmd = do_mouse_set,
         .mhandler.cmd = do_wav_capture,
         .mhandler.cmd = do_stop_capture,
I'd prefer we skip wav capture.
         .mhandler.cmd = do_boot_set,
         .mhandler.cmd = do_inject_nmi,
         .mhandler.cmd = drive_hot_add,
         .mhandler.cmd = net_host_device_add,
         .mhandler.cmd = net_host_device_remove,
         .mhandler.cmd = net_slirp_hostfwd_add,
         .mhandler.cmd = net_slirp_hostfwd_remove,
         .mhandler.cmd = do_watchdog_action,
         .mhandler.cmd = do_acl_show,
         .mhandler.cmd = do_acl_policy,
         .mhandler.cmd = do_acl_add,
         .mhandler.cmd = do_acl_remove,
         .mhandler.cmd = do_acl_reset,
         .mhandler.cmd = do_inject_mce,
    $ grep 'mhandler.info' monitor.c | grep -v info_new | grep -v async
         .mhandler.info = do_info_network,
         .mhandler.info = do_info_registers,
         .mhandler.info = do_info_history,
         .mhandler.info = irq_info,
         .mhandler.info = pic_info,
         .mhandler.info = tlb_info,
         .mhandler.info = mem_info,
         .mhandler.info = do_info_jit,
         .mhandler.info = do_info_numa,
         .mhandler.info = usb_info,
         .mhandler.info = usb_host_info,
         .mhandler.info = do_info_profile,
         .mhandler.info = do_info_capture,
         .mhandler.info = do_info_snapshots,
         .mhandler.info = pcmcia_info,
         .mhandler.info = do_info_cpu_stats,
         .mhandler.info = do_info_usernet,
         .mhandler.info = do_info_qtree,
         .mhandler.info = do_info_qdm,
         .mhandler.info = do_info_roms,

I'd rather not convert info commands until there were users. Info commands don't map well to QMP because of their lack of structure.

Regards,

Anthony Liguori

I don't think we can claim all those are irrelevant for QMP.

So are we still targetting complete conversion of relevant commands
for 0.13, or is it just going to be a stepping stone where declare
QMP stable, but known to be incomplete for coverage of commands ?

Daniel

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux