Re: [PATCH v2 2/6] KVM: Rename functions related to enabling virtualization hardware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 21, 2024 at 07:28:23PM -0700, Sean Christopherson wrote:
>Rename the various functions that enable virtualization to prepare for
>upcoming changes, and to clean up artifacts of KVM's previous behavior,
>which required manually juggling locks around kvm_usage_count.
>
>Drop the "nolock" qualifier from per-CPU functions now that there are no
>"nolock" implementations of the "all" variants, i.e. now that calling a
>non-nolock function from a nolock function isn't confusing (unlike this
>sentence).
>
>Drop "all" from the outer helpers as they no longer manually iterate
>over all CPUs, and because it might not be obvious what "all" refers to.
>Instead, use double-underscores to communicate that the per-CPU functions
>are helpers to the outer APIs.
>
>Opportunistically prepend "kvm" to all functions to help make it clear
>that they are KVM helpers, but mostly there's no reason not to.
>
>Lastly, use "virtualization" instead of "hardware", because while the
>functions do enable virtualization in hardware, there are a _lot_ of
>things that KVM enables in hardware.
>
>Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>

Reviewed-by: Chao Gao <chao.gao@xxxxxxxxx>




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux