On Fri, 2024-05-17 at 16:26 +1200, Huang, Kai wrote: > > I think I am just too obsessed on avoiding using kvm_gfn_shared_mask() > > so I'll stop commenting/replying on this. I think you just need to stick with it and discuss it a little more. The pattern seems to go: 1. You comment somewhere saying you want to get rid of kvm_gfn_shared_mask() 2. I ask about how it can work 3. We don't get to the bottom of it 4. Go to step 1 I think you are seeing bad code, but the communication is leaving me seriously confused. The rework Isaku and I were doing in the other thread still includes a shared mask in the core MMU code, so it's still open at this point.
