On Fri, Apr 12, 2024 at 09:42:12AM +0100, Steven Price wrote: > diff --git a/arch/arm64/include/asm/rsi_cmds.h b/arch/arm64/include/asm/rsi_cmds.h > index b4cbeafa2f41..c1850aefe54e 100644 > --- a/arch/arm64/include/asm/rsi_cmds.h > +++ b/arch/arm64/include/asm/rsi_cmds.h > @@ -10,6 +10,9 @@ > > #include <asm/rsi_smc.h> > > +#define GRANULE_SHIFT 12 > +#define GRANULE_SIZE (_AC(1, UL) << GRANULE_SHIFT) The name is too generic and it goes into a header file. Also maybe move it to rsi.h, and use it for other definitions like rsi_config struct size and alignment. -- Catalin
