Re: [kvm-unit-tests PATCH v3 0/5] add shellcheck support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 01/05/2024 13.29, Nicholas Piggin wrote:
This is based on upstream directly now, not ahead of the powerpc

Thanks! ... maybe you could also rebase the powerpc series on this now? (I haven't forgotten about it, just did not find enough spare time for more reviewing yet)

Since v2:
- Rebased to upstream with some patches merged.
- Just a few comment typos and small issues (e.g., quoting
   `make shellcheck` in docs) that people picked up from the
   last round.

When I now run "make shellcheck", I'm still getting an error:

In config.mak line 16:
^-- SC2209 (warning): Use var=$(command) to assign output (or quote to assign string).

Not sure why it's complaining about "ar" but not about the other lines in there?

Also, it only seems to work for in-tree builds. If I run it from an out-of-tree build directory, I get:

*/efi/run: */efi/run: openBinaryFile: does not exist (No such file or directory)


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux