Thanks for the fixes. On 5/1/24 6:59 AM, Mark Brown wrote: > On Tue, Apr 30, 2024 at 11:50:09PM +0000, Edward Liaw wrote: >> 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced >> asprintf into kselftest_harness.h, which is a GNU extension and needs >> _GNU_SOURCE to either be defined prior to including headers or with the >> -D_GNU_SOURCE flag passed to the compiler. > > This seems like something that should be handled centrally rather than > having to go round and audit the users every time some update is made. The easiest way I could think of is to add -D_GNU_SOURCE to KHDR_HEADERS definition in tools/testing/selftests/Makefile. It wouldn't be obvious from KHDR_HEADERS name that there could be other flags in it as well though. -- BR, Muhammad Usama Anjum