Re: [PATCH V5 4/4] KVM: selftests: Add test for configure of x86 APIC bus frequency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Zide,

On 4/26/2024 10:38 PM, Chen, Zide wrote:
> On 4/26/2024 4:26 PM, Reinette Chatre wrote:
>> On 4/26/2024 4:06 PM, Chen, Zide wrote:
>>> On 4/25/2024 3:07 PM, Reinette Chatre wrote:
>>>> diff --git a/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>>>> new file mode 100644
>>>> index 000000000000..5100b28228af
>>>> --- /dev/null
>>>> +++ b/tools/testing/selftests/kvm/x86_64/apic_bus_clock_test.c
>>>> @@ -0,0 +1,166 @@
>>>> +// SPDX-License-Identifier: GPL-2.0-only
>>>> +/*
>>>> + * Test configure of APIC bus frequency.
>>>> + *
>>>> + * Copyright (c) 2024 Intel Corporation
>>>> + *
>>>> + * To verify if the APIC bus frequency can be configured this test starts
>>>
>>> Nit: some typos here?
>>
>> Apologies but this is not obvious to me. Could you please help
>> by pointing out all those typos to me?
> 
> Do you think it's more readable to add a ","?
> 
> - * To verify if the APIC bus frequency can be configured this test starts
> + * To verify if the APIC bus frequency can be configured, this test starts
>   * by setting the TSC frequency in KVM, and then:

Sure. I'll do so in the next version.

Thank you.

Reinette




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux