[kvm-unit-tests GIT PULL 11/13] s390x: Use local accel variable in arch_cmd_s390x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Nicholas Piggin <npiggin@xxxxxxxxx>

By the time we end up in arch_cmd_s390x() the global ACCEL variable
has already been processed and is passed to arch_cmd_s390x() as an
argument. We should use the local argument to achieve the correct
behavior and not rely on global variables.

Fix this by changing ACCEL to lower case.

Reported-by: shellcheck SC2153
Reviewed-by: Andrew Jones <andrew.jones@xxxxxxxxx>
Acked-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
Signed-off-by: Nicholas Piggin <npiggin@xxxxxxxxx>
Link: https://lore.kernel.org/r/20240406122456.405139-2-npiggin@xxxxxxxxx
Message-ID: <20240406122456.405139-2-npiggin@xxxxxxxxx>
[frankja@xxxxxxxxxxxxx: Improved commit message]
Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
 scripts/s390x/func.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/s390x/func.bash b/scripts/s390x/func.bash
index 6c75e89a..fa47d019 100644
--- a/scripts/s390x/func.bash
+++ b/scripts/s390x/func.bash
@@ -21,7 +21,7 @@ function arch_cmd_s390x()
 	"$cmd" "$testname" "$groups" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout"
 	# run PV test case
-	if [ "$ACCEL" = 'tcg' ] || grep -q "migration" <<< "$groups"; then
+	if [ "$accel" = 'tcg' ] || grep -q "migration" <<< "$groups"; then

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux