On 4/23/2024 6:15 AM, Binbin Wu wrote: > > > On 4/17/2024 2:23 AM, Reinette Chatre wrote: >> Hi Isaku, >> >> (In shortlog "tdexit" can be "TD exit" to be consistent with >> documentation.) >> >> On 2/26/2024 12:26 AM, isaku.yamahata@xxxxxxxxx wrote: >>> From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx> >>> >>> This corresponds to VMX __vmx_complete_interrupts(). Because TDX >>> virtualize vAPIC, KVM only needs to care NMI injection. >> This seems to be the first appearance of NMI and the changelog >> is very brief. How about expending it with: >> >> "This corresponds to VMX __vmx_complete_interrupts(). Because TDX >> virtualize vAPIC, KVM only needs to care about NMI injection. > ^ > virtualizes > > Also, does it need to mention that non-NMI interrupts are handled by posted-interrupt mechanism? > > For example: > > "This corresponds to VMX __vmx_complete_interrupts(). Because TDX > virtualizes vAPIC, and non-NMI interrupts are delivered using posted-interrupt > mechanism, KVM only needs to care about NMI injection. > ... > " > Thank you Binbin. Looks good to me. Reinette
