Hi Jason, On Mon, Apr 22, 2024 at 1:54 PM Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > On Mon, Apr 22, 2024 at 09:27:18AM +0200, Geert Uytterhoeven wrote: > > > +if IOMMUFD > > > +config IOMMUFD_TEST > > > + bool "IOMMU Userspace API Test support" > > > + depends on DEBUG_KERNEL > > > + depends on FAULT_INJECTION > > > + depends on RUNTIME_TESTING_MENU > > > + default n > > > + help > > > + This is dangerous, do not enable unless running > > > + tools/testing/selftests/iommu > > > +endif > > > > How dangerous is this? > > I.e. is it now unsafe to run an allyesconfig or allmodconfig kernel? > > Depends what you mean by unsafe? This is less unsafe than /dev/mem, > for instance.. It does nothing unless poked by userspace. OK, so the test itself does not cause a crash, or data corruption? > > Probably this symbol should be tristate? > > It is not a seperate module. Perhaps it should be? ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds