Hi Brendan,
On Mon, Apr 15, 2024 at 03:42:44PM +0000, Brendan Jackman wrote:
> KVM docs[1] for KVM_CREATE_PIT2 say:
>
> This call is only valid after enabling in-kernel irqchip support
> via KVM_CREATE_IRQCHIP.
>
> This was not enforced technically, until kernel commit 9e05d9b06757
> ("KVM: x86: Check irqchip mode before create PIT"). Now I get -ENOENT.
>
> To fix it I've just reordered the ioctls. Doing this fixes the -ENOENT
> when running a nested VM on VMX.
>
> [1] https://www.kernel.org/doc/Documentation/virtual/kvm/api.txt
>
> Signed-off-by: Brendan Jackman <jackmanb@xxxxxxxxxx>
> To: Will Deacon <will@xxxxxxxxxx>
> To: Julien Thierry <julien.thierry.kdev@xxxxxxxxx>
> To: kvm@xxxxxxxxxxxxxxx
> ---
> x86/kvm.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Thanks for the patch, but I think we already fixed this in e73a6b29f1eb
("x86: Enable in-kernel irqchip before creating PIT"). Please can you
check the latest kvmtool works for you?
Cheers,
Will
