On 4/18/24 21:20, Andrew Jones wrote:
> On Thu, Apr 18, 2024 at 05:55:49PM +0200, Jan Richter wrote:
>> The test_migrate_unmapped_collection test fails when the errata
>> requirements are not meet and the test should be skipped. Instead of
>
> met
>
>> being skipped, the test returns `ERROR: Test exit before migration
>> point.`
>>
>> This is caused by changes in fa8914bccc226db86bd70d71bfd6022db252fc78
>
> Please use the standard way of referencing commits, which, in this case,
> would be
>
> commit fa8914bccc22 ("migration: Add a migrate_skip command")
>
>> which changes the behaviour of skipped migration tests. This fixes this
>> issue by adding migrate_skip() method to
>> test_migrate_unmapped_collection.
>
> And we should add a Fixes tag
>
> Fixes: fa8914bccc22 ("migration: Add a migrate_skip command")
>
>>
>> Signed-off-by: Jan Richter <jarichte@xxxxxxxxxx>
>> ---
>> arm/gic.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arm/gic.c b/arm/gic.c
>> index bbf828f1..256dd80d 100644
>> --- a/arm/gic.c
>> +++ b/arm/gic.c
>> @@ -829,6 +829,7 @@ static void test_migrate_unmapped_collection(void)
>> if (!errata(ERRATA_UNMAPPED_COLLECTIONS)) {
>> report_skip("Skipping test, as this test hangs without the fix. "
>> "Set %s=y to enable.", ERRATA_UNMAPPED_COLLECTIONS);
>> + migrate_skip();
>> return;
>> }
>>
>> --
>> 2.44.0
>>
>
> Otherwise LGTM
>
> Thanks,
> drew
>
Hi Drew,
thanks for the review. I will send new version with fixed commit message.
- Jan
