Re: [PATCH v2 03/10] KVM: x86/mmu: Extract __kvm_mmu_do_page_fault()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 03/10] KVM: x86/mmu: Extract __kvm_mmu_do_page_fault()
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Wed, 17 Apr 2024 17:41:55 +0200
Cc: "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "seanjc@xxxxxxxxxx" <seanjc@xxxxxxxxxx>, "Huang, Kai" <kai.huang@xxxxxxxxx>, "federico.parola@xxxxxxxxx" <federico.parola@xxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "isaku.yamahata@xxxxxxxxx" <isaku.yamahata@xxxxxxxxx>, "dmatlack@xxxxxxxxxx" <dmatlack@xxxxxxxxxx>, "michael.roth@xxxxxxx" <michael.roth@xxxxxxx>, isaku.yamahata@xxxxxxxxxxxxxxx
In-reply-to: <20240416235230.GB3039520@ls.amr.corp.intel.com>
References: <cover.1712785629.git.isaku.yamahata@intel.com> <ddf1d98420f562707b11e12c416cce8fdb986bb1.1712785629.git.isaku.yamahata@intel.com> <621c260399a05338ba6d034e275e19714ad3665c.camel@intel.com> <20240416235230.GB3039520@ls.amr.corp.intel.com>

On Wed, Apr 17, 2024 at 1:52 AM Isaku Yamahata <isaku.yamahata@xxxxxxxxx> wrote:
> As Chao pointed out, this patch is unnecessary.  I'll use
> kvm_mmu_do_page_fault() directly with updating vcpu->stat.

Actually I prefer to have this patch.

pf_* stats do not make sense for pre-population, and updating them
confuses things because pre-population (outside TDX) has the purpose
of avoiding page faults.

Paolo

References:
- [PATCH v2 00/10] KVM: Guest Memory Pre-Population API
  - From: isaku . yamahata
- [PATCH v2 03/10] KVM: x86/mmu: Extract __kvm_mmu_do_page_fault()
  - From: isaku . yamahata
- Re: [PATCH v2 03/10] KVM: x86/mmu: Extract __kvm_mmu_do_page_fault()
  - From: Edgecombe, Rick P
- Re: [PATCH v2 03/10] KVM: x86/mmu: Extract __kvm_mmu_do_page_fault()
  - From: Isaku Yamahata

Prev by Date: [PATCH 4/7] KVM: x86/mmu: Make __kvm_mmu_do_page_fault() return mapped level
Next by Date: Re: [BUG net-next] arch/x86/kernel/cpu/bugs.c:2935: "Unpatched return thunk in use. This should not happen!" [STACKTRACE]
Previous by thread: Re: [PATCH v2 03/10] KVM: x86/mmu: Extract __kvm_mmu_do_page_fault()
Next by thread: [PATCH v2 02/10] KVM: Add KVM_MAP_MEMORY vcpu ioctl to pre-populate guest memory
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]