On Thu, Apr 04, 2024, Venkatesh Srinivas wrote:
> except argument was not used.
Please write changelogs with a bit more verbosity. This one is easy enough to
fixup when applying, but for the future...
> Signed-off-by: Venkatesh Srinivas <venkateshs@xxxxxxxxxxxx>
> ---
> include/linux/kvm_host.h | 2 --
> virt/kvm/kvm_main.c | 10 +---------
> 2 files changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 9807ea98b568..5483a6af82a5 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -193,8 +193,6 @@ static inline bool is_error_page(struct page *page)
> bool kvm_make_vcpus_request_mask(struct kvm *kvm, unsigned int req,
> unsigned long *vcpu_bitmap);
> bool kvm_make_all_cpus_request(struct kvm *kvm, unsigned int req);
> -bool kvm_make_all_cpus_request_except(struct kvm *kvm, unsigned int req,
> - struct kvm_vcpu *except);
>
> #define KVM_USERSPACE_IRQ_SOURCE_ID 0
> #define KVM_IRQFD_RESAMPLE_IRQ_SOURCE_ID 1
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index d1fd9cb5d037..53351febb813 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -311,8 +311,7 @@ bool kvm_make_vcpus_request_mask(struct kvm *kvm, unsigned int req,
> return called;
> }
>
> -bool kvm_make_all_cpus_request_except(struct kvm *kvm, unsigned int req,
> - struct kvm_vcpu *except)
> +bool kvm_make_all_cpus_request(struct kvm *kvm, unsigned int req)
> {
> struct kvm_vcpu *vcpu;
> struct cpumask *cpus;
> @@ -326,8 +325,6 @@ bool kvm_make_all_cpus_request_except(struct kvm *kvm, unsigned int req,
> cpumask_clear(cpus);
>
> kvm_for_each_vcpu(i, vcpu, kvm) {
Nit, curly braces are no longer necessary (also can fixup when applying).
> - if (vcpu == except)
> - continue;
> kvm_make_vcpu_request(vcpu, req, cpus, me);
> }
>
> @@ -336,11 +333,6 @@ bool kvm_make_all_cpus_request_except(struct kvm *kvm, unsigned int req,
>
> return called;
> }
> -
> -bool kvm_make_all_cpus_request(struct kvm *kvm, unsigned int req)
> -{
> - return kvm_make_all_cpus_request_except(kvm, req, NULL);
> -}
> EXPORT_SYMBOL_GPL(kvm_make_all_cpus_request);
>
> void kvm_flush_remote_tlbs(struct kvm *kvm)
> --
> 2.44.0.478.gd926399ef9-goog
>
